Merge pull request #217 from Araxeus/Refresh-menu-on-plugin-enable/disable

Refresh menu on plugin enable/disable (show/hide submenu)
This commit is contained in:
th-ch
2021-04-02 21:43:12 +02:00
committed by GitHub
2 changed files with 24 additions and 26 deletions

16
menu.js
View File

@ -7,7 +7,7 @@ const is = require("electron-is");
const { getAllPlugins } = require("./plugins/utils");
const config = require("./config");
const pluginEnabledMenu = (plugin, label = "") => ({
const pluginEnabledMenu = (win, plugin, label = "", hasSubmenu=false) => ({
label: label || plugin,
type: "checkbox",
checked: config.plugins.isEnabled(plugin),
@ -17,6 +17,9 @@ const pluginEnabledMenu = (plugin, label = "") => ({
} else {
config.plugins.disable(plugin);
}
if(hasSubmenu) {
this.setApplicationMenu(win);
}
},
});
@ -27,16 +30,15 @@ const mainMenuTemplate = (win) => [
...getAllPlugins().map((plugin) => {
const pluginPath = path.join(__dirname, "plugins", plugin, "menu.js");
if (!config.plugins.isEnabled(plugin)) {
return pluginEnabledMenu(plugin);
}
if (existsSync(pluginPath)) {
if (!config.plugins.isEnabled(plugin)) {
return pluginEnabledMenu(win, plugin, "", true);
}
const getPluginMenu = require(pluginPath);
return {
label: plugin,
submenu: [
pluginEnabledMenu(plugin, "Enabled"),
pluginEnabledMenu(win, plugin, "Enabled", true),
...getPluginMenu(win, config.plugins.getOptions(plugin), () =>
module.exports.setApplicationMenu(win)
),
@ -44,7 +46,7 @@ const mainMenuTemplate = (win) => [
};
}
return pluginEnabledMenu(plugin);
return pluginEnabledMenu(win, plugin);
}),
{ type: "separator" },
{

View File

@ -3,18 +3,18 @@ const { Menu } = require('electron');
const path = require('path');
const electronLocalshortcut = require("electron-localshortcut");
const config = require('../../config');
var { mainMenuTemplate } = require("../../menu");
const { setApplicationMenu } = require("../../menu");
//override menu template for custom menu
const originTemplate = mainMenuTemplate;
mainMenuTemplate = function (winHook) {
//get template
let template = originTemplate(winHook);
//override Menu.buildFromTemplate, making it also fix the template
const originBuildMenu = Menu.buildFromTemplate;
//this function natively gets called on all submenu so no more reason to use recursion
Menu.buildFromTemplate = function (template) {
//fix checkbox and roles
fixMenu(template);
//return as normal
return template;
return originBuildMenu(template);
}
//win hook for fixing menu
let win;
@ -31,9 +31,9 @@ module.exports = winImport => {
return
}
done = true;
let template = mainMenuTemplate(win);
let menu = Menu.buildFromTemplate(template);
Menu.setApplicationMenu(menu);
//refresh menu to fix it
setApplicationMenu(win);
//register keyboard shortcut && hide menu if hideMenu is enabled
if (config.get('options.hideMenu')) {
@ -53,21 +53,17 @@ function switchMenuVisibility() {
//go over each item in menu
function fixMenu(template) {
for (let index in template) {
let item = template[index];
//apply function on submenu
if (item.submenu != null) {
fixMenu(item.submenu);
}
//change onClick of checkbox+radio
else if (item.type === 'checkbox' || item.type === 'radio') {
for (let item of template) {
//change onClick of checkbox+radio if not fixed
if ((item.type === 'checkbox' || item.type === 'radio') && !item.fixed) {
let ogOnclick = item.click;
item.click = (itemClicked) => {
ogOnclick(itemClicked);
checkCheckbox(itemClicked);
};
item.fixed = true;
}
//customize roles
//customize roles (will be deleted soon)
else if (item.role != null) {
fixRoles(item)
}