smueller/youtube-music
1
0
Fork 0
mirror of https://github.com/th-ch/youtube-music.git synced 2026-01-11 10:31:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(downloader): fix memory leak reported in #1791

Browse Source
This commit is contained in:
JellyBrick
2024-02-26 19:13:22 +09:00
parent 34f5411aec
commit fd6ba1eda1
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/plugins/downloader/main/index.ts
View File

@ -1,5 +1,4 @@
import { import {
createWriteStream,
existsSync, existsSync,
mkdirSync, mkdirSync,
writeFileSync, writeFileSync,
@ -297,7 +296,7 @@ async function downloadSongUnsafe(
mkdirSync(dir); mkdirSync(dir);
} }
const fileBuffer = await iterableStreamToTargetFile( let fileBuffer = await iterableStreamToTargetFile(
iterableStream, iterableStream,
targetFileExtension, targetFileExtension,
metadata, metadata,
@ -307,19 +306,16 @@ async function downloadSongUnsafe(
increasePlaylistProgress, increasePlaylistProgress,
); );
if (fileBuffer && targetFileExtension === 'mp3') {
fileBuffer = await writeID3(
Buffer.from(fileBuffer),
metadata,
sendFeedback,
);
}
if (fileBuffer) { if (fileBuffer) {
if (targetFileExtension !== 'mp3') { writeFileSync(filePath, fileBuffer);
createWriteStream(filePath).write(fileBuffer);
} else {
const buffer = await writeID3(
Buffer.from(fileBuffer),
metadata,
sendFeedback,
);
if (buffer) {
writeFileSync(filePath, buffer);
}
}
} }
sendFeedback(null, -1); sendFeedback(null, -1);