fix: build performance

vite-plugins/plugin-loader.mts

@@ -1,4 +1,4 @@
-import { readFile } from 'node:fs/promises';
+import { readFileSync } from 'node:fs';
 import { resolve, basename, dirname } from 'node:path';
 import { fileURLToPath } from 'node:url';
 
@@ -8,10 +8,34 @@ import {
   ts,
   ObjectLiteralExpression,
   VariableDeclarationKind,
+  Node,
+  type ObjectLiteralElementLike,
 } from 'ts-morph';
 
 import type { PluginOption } from 'vite';
 
+// Initialize a global project instance to reuse across load calls
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const globalProject = new Project({
+  tsConfigFilePath: resolve(__dirname, '..', 'tsconfig.json'),
+  skipAddingFilesFromTsConfig: true,
+  skipLoadingLibFiles: true,
+  skipFileDependencyResolution: true,
+});
+
+// Helper to extract a property’s name from its node
+const getPropertyName = (prop: Node): string | null => {
+  const kind = prop.getKind();
+  if (
+    kind === ts.SyntaxKind.PropertyAssignment ||
+    kind === ts.SyntaxKind.ShorthandPropertyAssignment ||
+    kind === ts.SyntaxKind.MethodDeclaration
+  ) {
+    return prop.getFirstChildByKindOrThrow(ts.SyntaxKind.Identifier).getText();
+  }
+  return null;
+};
+
 export default function (
   mode: 'backend' | 'preload' | 'renderer' | 'none',
 ): PluginOption {
@@ -22,131 +46,96 @@ export default function (
 
   return {
     name: 'ytm-plugin-loader',
-    async load(id) {
+    load(id) {
       if (!pluginFilter(id)) return null;
 
-      const __dirname = dirname(fileURLToPath(import.meta.url));
-
-      const project = new Project({
-        tsConfigFilePath: resolve(__dirname, '..', 'tsconfig.json'),
-        skipAddingFilesFromTsConfig: true,
-        skipLoadingLibFiles: true,
-        skipFileDependencyResolution: true,
-      });
-
-      const src = project.createSourceFile(
+      // Read file asynchronously
+      const fileContent = readFileSync(id, 'utf8');
+      // Create or update source file in the global project instance
+      const src = globalProject.createSourceFile(
         '_pf' + basename(id),
-        await readFile(id, 'utf8'),
+        fileContent,
+        { overwrite: true },
       );
+
       const exports = src.getExportedDeclarations();
-      let objExpr: ObjectLiteralExpression | undefined = undefined;
+      let objExpr: ObjectLiteralExpression | undefined;
 
-      for (const [name, [expr]] of exports) {
-        if (name !== 'default') continue;
-
-        switch (expr.getKind()) {
-          case ts.SyntaxKind.ObjectLiteralExpression: {
-            objExpr = expr.asKindOrThrow(ts.SyntaxKind.ObjectLiteralExpression);
-            break;
-          }
-          case ts.SyntaxKind.CallExpression: {
-            const callExpr = expr.asKindOrThrow(ts.SyntaxKind.CallExpression);
-            if (callExpr.getArguments().length !== 1) continue;
-
-            const name = callExpr.getExpression().getText();
-            if (name !== 'createPlugin') continue;
+      // Identify the default export as an object literal, or via a 'createPlugin' call
+      for (const [exportName, declarations] of exports) {
+        if (exportName !== 'default') continue;
+        const expr = declarations[0];
 
+        const exprKind = expr.getKind();
+        if (exprKind === ts.SyntaxKind.ObjectLiteralExpression) {
+          objExpr = expr.asKindOrThrow(ts.SyntaxKind.ObjectLiteralExpression);
+          break;
+        } else if (exprKind === ts.SyntaxKind.CallExpression) {
+          const callExpr = expr.asKindOrThrow(ts.SyntaxKind.CallExpression);
+          if (
+            callExpr.getArguments().length === 1 &&
+            callExpr.getExpression().getText() === 'createPlugin'
+          ) {
             const arg = callExpr.getArguments()[0];
-            if (arg.getKind() !== ts.SyntaxKind.ObjectLiteralExpression)
-              continue;
-
-            objExpr = arg.asKindOrThrow(ts.SyntaxKind.ObjectLiteralExpression);
-            break;
+            if (arg.getKind() === ts.SyntaxKind.ObjectLiteralExpression) {
+              objExpr = arg.asKindOrThrow(
+                ts.SyntaxKind.ObjectLiteralExpression,
+              );
+              break;
+            }
           }
         }
       }
 
       if (!objExpr) return null;
 
-      const properties = objExpr.getProperties();
-      const propertyNames = properties.map((prop) => {
-        switch (prop.getKind()) {
-          case ts.SyntaxKind.PropertyAssignment:
-            return prop
-              .asKindOrThrow(ts.SyntaxKind.PropertyAssignment)
-              .getName();
-          case ts.SyntaxKind.ShorthandPropertyAssignment:
-            return prop
-              .asKindOrThrow(ts.SyntaxKind.ShorthandPropertyAssignment)
-              .getName();
-          case ts.SyntaxKind.MethodDeclaration:
-            return prop
-              .asKindOrThrow(ts.SyntaxKind.MethodDeclaration)
-              .getName();
-          default:
-            throw new Error('Not implemented');
-        }
-      });
+      // Build a map of property names to their AST nodes for fast lookup
+      const propMap = new Map<string, ObjectLiteralElementLike>();
+      for (const prop of objExpr.getProperties()) {
+        const name = getPropertyName(prop);
+        if (name) propMap.set(name, prop);
+      }
 
       const contexts = ['backend', 'preload', 'renderer', 'menu'];
       for (const ctx of contexts) {
-        if (mode === 'none') {
-          const index = propertyNames.indexOf(ctx);
-          if (index === -1) continue;
-
-          objExpr.getProperty(propertyNames[index])?.remove();
+        if (mode === 'none' && propMap.has(ctx)) {
+          propMap.get(ctx)?.remove();
           continue;
         }
-
-        if (ctx === mode) continue;
-        if (ctx === 'menu' && mode === 'backend') continue;
-
-        const index = propertyNames.indexOf(ctx);
-        if (index === -1) continue;
-
-        objExpr.getProperty(propertyNames[index])?.remove();
+        if (ctx === mode || (ctx === 'menu' && mode === 'backend')) continue;
+        if (propMap.has(ctx)) propMap.get(ctx)?.remove();
       }
 
-      const stubObjExpr = src
-        .addVariableStatement({
-          isExported: true,
-          declarationKind: VariableDeclarationKind.Const,
-          declarations: [
-            {
-              name: 'pluginStub',
-              initializer: (writer) => writer.write(objExpr.getText()),
-            },
-          ],
-        })
-        .getDeclarations()[0]
-        .getInitializer() as ObjectLiteralExpression;
-
-      const stubProperties = stubObjExpr.getProperties();
-      const stubPropertyNames = stubProperties.map((prop) => {
-        switch (prop.getKind()) {
-          case ts.SyntaxKind.PropertyAssignment:
-            return prop
-              .asKindOrThrow(ts.SyntaxKind.PropertyAssignment)
-              .getName();
-          case ts.SyntaxKind.ShorthandPropertyAssignment:
-            return prop
-              .asKindOrThrow(ts.SyntaxKind.ShorthandPropertyAssignment)
-              .getName();
-          case ts.SyntaxKind.MethodDeclaration:
-            return prop
-              .asKindOrThrow(ts.SyntaxKind.MethodDeclaration)
-              .getName();
-          default:
-            throw new Error('Not implemented');
-        }
+      // Add an exported variable 'pluginStub' with the modified object literal's text
+      const varStmt = src.addVariableStatement({
+        isExported: true,
+        declarationKind: VariableDeclarationKind.Const,
+        declarations: [
+          {
+            name: 'pluginStub',
+            initializer: (writer) => writer.write(objExpr.getText()),
+          },
+        ],
       });
+      const stubObjExpr = varStmt
+        .getDeclarations()[0]
+        .getInitializerIfKindOrThrow(ts.SyntaxKind.ObjectLiteralExpression);
 
-      if (mode === 'backend') contexts.pop();
-      for (const ctx of contexts) {
-        const index = stubPropertyNames.indexOf(ctx);
-        if (index === -1) continue;
+      // Similarly build a map for the stub properties
+      const stubMap = new Map<string, ObjectLiteralElementLike>();
+      for (const prop of stubObjExpr.getProperties()) {
+        const name = getPropertyName(prop);
+        if (name) stubMap.set(name, prop);
+      }
 
-        stubObjExpr.getProperty(stubPropertyNames[index])?.remove();
+      const stubContexts =
+        mode === 'backend'
+          ? contexts.filter((ctx) => ctx !== 'backend')
+          : contexts;
+      for (const ctx of stubContexts) {
+        if (stubMap.has(ctx)) {
+          stubMap.get(ctx)?.remove();
+        }
       }
 
       return {