smueller/youtube-music
1
0
Fork 0
mirror of https://github.com/th-ch/youtube-music.git synced 2026-01-11 10:31:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #216 from Araxeus/fix-duplicate-notification

Browse Source 
[Notification Plugin] Fix duplicate notification
This commit is contained in:
th-ch
2021-04-02 23:10:19 +02:00
committed by GitHub
parent 2254cac15b a3ec9b7b78
commit c7bef5ac7b
4 changed files with 30 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
config/defaults.js
View File

@ -42,7 +42,8 @@ const defaultConfig = {
}, },
notifications: { notifications: {
enabled: false, enabled: false,
urgency: "normal" urgency: "normal",
unpauseNotification: false
} }
}, },
}; };

16
plugins/notifications/back.js
View File

@ -18,7 +18,7 @@ const notify = (info, options) => {
}; };
// Send the notification // Send the notification
currentNotification = new Notification(notification); const currentNotification = new Notification(notification);
currentNotification.show() currentNotification.show()
return currentNotification; return currentNotification;
@ -27,11 +27,21 @@ const notify = (info, options) => {
module.exports = (win, options) => { module.exports = (win, options) => {
const registerCallback = getSongInfo(win); const registerCallback = getSongInfo(win);
let oldNotification; let oldNotification;
let oldURL = "";
win.on("ready-to-show", () => { win.on("ready-to-show", () => {
// Register the callback for new song information // Register the callback for new song information
registerCallback(songInfo => { registerCallback(songInfo => {
// If song is playing send notification // on pause - reset url? and skip notification
if (!songInfo.isPaused) { if (songInfo.isPaused) {
//reset oldURL if unpause notification option is on
if (options.unpauseNotification) {
oldURL = "";
}
return;
}
// If url isn't the same as last one - send notification
if (songInfo.url !== oldURL) {
oldURL = songInfo.url;
// Close the old notification // Close the old notification
oldNotification?.close(); oldNotification?.close();
// This fixes a weird bug that would cause the notification to be updated instead of showing // This fixes a weird bug that would cause the notification to be updated instead of showing

8
plugins/notifications/menu.js
View File

@ -1,4 +1,4 @@
const {urgencyLevels, setUrgency} = require("./utils"); const {urgencyLevels, setUrgency, setUnpause} = require("./utils");
module.exports = (win, options) => [ module.exports = (win, options) => [
{ {
@ -10,4 +10,10 @@ module.exports = (win, options) => [
click: () => setUrgency(options, level.value) click: () => setUrgency(options, level.value)
})), })),
}, },
{
label: "Show notification on unpause",
type: "checkbox",
checked: options.unpauseNotification,
click: (item) => setUnpause(options, item.checked)
}
]; ];

8
plugins/notifications/utils.js
View File

@ -7,5 +7,13 @@ module.exports.urgencyLevels = [
]; ];
module.exports.setUrgency = (options, level) => { module.exports.setUrgency = (options, level) => {
options.urgency = level options.urgency = level
setOption(options)
};
module.exports.setUnpause = (options, value) => {
options.unpauseNotification = value
setOption(options)
};
let setOption = options => {
setOptions("notifications", options) setOptions("notifications", options)
}; };