From baeebd195962ccb8ea966ee2de4fbe6720f709c7 Mon Sep 17 00:00:00 2001 From: Araxeus <78568641+Araxeus@users.noreply.github.com> Date: Thu, 16 Dec 2021 19:15:55 +0200 Subject: [PATCH] downloader fixes * --experimental-wasm-bulk-memory * SharedArrayBuffer * getFolder from front * ytdl-core 4.9.2 --- index.js | 3 ++- package.json | 2 +- plugins/downloader/utils.js | 4 +--- plugins/downloader/youtube-dl.js | 5 +++-- yarn.lock | 18 +++++++++--------- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/index.js b/index.js index 6b65adc7..6fcd2aa1 100644 --- a/index.js +++ b/index.js @@ -26,8 +26,9 @@ const app = electron.app; app.commandLine.appendSwitch( "js-flags", // WebAssembly flags - "--experimental-wasm-threads --experimental-wasm-bulk-memory" + "--experimental-wasm-threads" ); +app.commandLine.appendSwitch('enable-features', "SharedArrayBuffer"); // Fix downloader bug app.allowRendererProcessReuse = true; // https://github.com/electron/electron/issues/18397 if (config.get("options.disableHardwareAcceleration")) { if (is.dev()) { diff --git a/package.json b/package.json index 9bb05900..f4a1c97f 100644 --- a/package.json +++ b/package.json @@ -86,7 +86,7 @@ "mpris-service": "^2.1.2", "node-fetch": "^2.6.6", "node-notifier": "^9.0.1", - "ytdl-core": "^4.9.1", + "ytdl-core": "^4.9.2", "ytpl": "^2.2.3" }, "devDependencies": { diff --git a/plugins/downloader/utils.js b/plugins/downloader/utils.js index 88eeba01..40e5969f 100644 --- a/plugins/downloader/utils.js +++ b/plugins/downloader/utils.js @@ -1,8 +1,6 @@ const electron = require("electron"); -//const remote = require('@electron/remote'); -module.exports.getFolder = (customFolder) => - customFolder || electron.app.getPath("downloads"); +module.exports.getFolder = customFolder => customFolder || electron.app.getPath("downloads"); module.exports.defaultMenuDownloadLabel = "Download playlist"; const orderedQualityList = ["maxresdefault", "hqdefault", "mqdefault", "sdddefault"]; diff --git a/plugins/downloader/youtube-dl.js b/plugins/downloader/youtube-dl.js index 906fc35c..345f3ff2 100644 --- a/plugins/downloader/youtube-dl.js +++ b/plugins/downloader/youtube-dl.js @@ -3,6 +3,7 @@ const { join } = require("path"); const Mutex = require("async-mutex").Mutex; const { ipcRenderer } = require("electron"); +const remote = require('@electron/remote'); const is = require("electron-is"); const filenamify = require("filenamify"); @@ -14,7 +15,7 @@ const ytdl = require("ytdl-core"); const { triggerAction, triggerActionSync } = require("../utils"); const { ACTIONS, CHANNEL } = require("./actions.js"); -const { getFolder, urlToJPG } = require("./utils"); +const { urlToJPG } = require("./utils"); const { cleanupName } = require("../../providers/song-info"); const { createFFmpeg } = FFmpeg; @@ -135,7 +136,7 @@ const toMP3 = async ( safeVideoName + "." + extension ); - const folder = getFolder(options.downloadFolder); + const folder = options.downloadFolder || remote.app.getPath("downloads"); const name = metadata.title ? `${metadata.artist ? `${metadata.artist} - ` : ""}${metadata.title}` : videoName; diff --git a/yarn.lock b/yarn.lock index b8698332..c25ed838 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6243,10 +6243,10 @@ lru-cache@^6.0.0: dependencies: yallist "^4.0.0" -m3u8stream@^0.8.3: - version "0.8.3" - resolved "https://registry.yarnpkg.com/m3u8stream/-/m3u8stream-0.8.3.tgz#c4624e92b4240eb356d040c4a5e155586cf58108" - integrity sha512-0nAcdrF8YJKUkb6PzWdvGftTPyCVWgoiot1AkNVbPKTeIGsWs6DrOjifrJ0Zi8WQfQmD2SuVCjkYIOip12igng== +m3u8stream@^0.8.4: + version "0.8.4" + resolved "https://registry.yarnpkg.com/m3u8stream/-/m3u8stream-0.8.4.tgz#15b49d0c2b510755ea43c1e53f85d7aaa4dc65c2" + integrity sha512-sco80Db+30RvcaIOndenX6E6oQNgTiBKeJbFPc+yDXwPQIkryfboEbCvXPlBRq3mQTCVPQO93TDVlfRwqpD35w== dependencies: miniget "^4.0.0" sax "^1.2.4" @@ -8921,12 +8921,12 @@ yocto-queue@^1.0.0: resolved "https://registry.yarnpkg.com/yocto-queue/-/yocto-queue-1.0.0.tgz#7f816433fb2cbc511ec8bf7d263c3b58a1a3c251" integrity sha512-9bnSc/HEW2uRy67wc+T8UwauLuPJVn28jb+GtJY16iiKWyvmYJRXVT4UamsAEGQfPohgr2q4Tq0sQbQlxTfi1g== -ytdl-core@^4.9.1: - version "4.9.1" - resolved "https://registry.yarnpkg.com/ytdl-core/-/ytdl-core-4.9.1.tgz#f587e2bd8329b5133c0bac4ce5ee1f3c7a1175a9" - integrity sha512-6Jbp5RDhUEozlaJQAR+l8oV8AHsx3WUXxSyPxzE6wOIAaLql7Hjiy0ZM58wZoyj1YEenlEPjEqcJIjKYKxvHtQ== +ytdl-core@^4.9.2: + version "4.9.2" + resolved "https://registry.yarnpkg.com/ytdl-core/-/ytdl-core-4.9.2.tgz#c2d1ec44ee3cabff35e5843c6831755e69ffacf0" + integrity sha512-aTlsvsN++03MuOtyVD4DRF9Z/9UAeeuiNbjs+LjQBAiw4Hrdp48T3U9vAmRPyvREzupraY8pqRoBfKGqpq+eHA== dependencies: - m3u8stream "^0.8.3" + m3u8stream "^0.8.4" miniget "^4.0.0" sax "^1.1.3"