fix: lifecycle check

edge case:
 - There may be plugins that don't have a start or stop function
This commit is contained in:
JellyBrick
2023-11-28 05:23:35 +09:00
parent bf27c73f1d
commit 90103d9853
4 changed files with 75 additions and 29 deletions

View File

@ -38,7 +38,7 @@ export const startPlugin = <Config extends PluginConfig>(id: string, def: Plugin
? def[options.ctx] as PluginLifecycleSimple<Config, unknown>
: (def[options.ctx] as PluginLifecycleExtra<Config, typeof options.context, unknown>)?.start;
if (!lifecycle) return false;
if (!lifecycle) return null;
try {
const defContext = def[options.ctx];
@ -57,17 +57,18 @@ export const startPlugin = <Config extends PluginConfig>(id: string, def: Plugin
return true;
} catch (err) {
console.log(`[YTM] Failed to start ${id}::${options.ctx}: ${String(err)}`);
console.error(`[YTM] Failed to start ${id}::${options.ctx}`);
console.trace(err);
return false;
}
};
export const stopPlugin = <Config extends PluginConfig>(id: string, def: PluginDef<unknown, unknown, unknown, Config>, options: Options<Config>) => {
if (!def[options.ctx]) return false;
if (!def || !def[options.ctx]) return false;
if (typeof def[options.ctx] === 'function') return false;
const stop = def[options.ctx] as PluginLifecycleSimple<Config, unknown>;
if (!stop) return false;
if (!stop) return null;
try {
const start = performance.now();
@ -77,9 +78,10 @@ export const stopPlugin = <Config extends PluginConfig>(id: string, def: PluginD
return true;
} catch (err) {
console.log(
`[YTM] Failed to execute ${id}::${options.ctx}: ${String(err)}`,
console.error(
`[YTM] Failed to execute ${id}::${options.ctx}`,
);
console.trace(err);
return false;
}
};