smueller/youtube-music
1
0
Fork 0
mirror of https://github.com/th-ch/youtube-music.git synced 2026-01-11 18:41:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: use '.call' instead of '.bind'

Browse Source
This commit is contained in:
JellyBrick
2023-11-29 01:27:51 +09:00
parent ae239f6700
commit 5db759150c
3 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/index.ts
View File

@ -165,7 +165,7 @@ const initHook = (win: BrowserWindow) => {
const mainPlugin = getAllLoadedMainPlugins()[id];
if (mainPlugin) {
if (config.enabled && typeof mainPlugin.backend !== 'function') {
mainPlugin.backend?.onConfigChange?.bind(mainPlugin.backend)?.(config);
mainPlugin.backend?.onConfigChange?.call(mainPlugin.backend, config);
}
}

6
src/renderer.ts
View File

@ -55,7 +55,7 @@ async function onApiLoaded() {
for (const [id, plugin] of Object.entries(getAllLoadedRendererPlugins())) {
if (typeof plugin.renderer !== 'function') {
await plugin.renderer?.onPlayerApiReady?.bind(plugin.renderer)?.(api!, createContext(id));
await plugin.renderer?.onPlayerApiReady?.call(plugin.renderer, api!, createContext(id));
}
}
@ -142,7 +142,7 @@ async function onApiLoaded() {
if (api) {
const plugin = getLoadedRendererPlugin(id);
if (plugin && typeof plugin.renderer !== 'function') {
plugin.renderer?.onPlayerApiReady?.bind(plugin.renderer)?.(api, createContext(id));
plugin.renderer?.onPlayerApiReady?.call(plugin.renderer, api, createContext(id));
}
}
},
@ -153,7 +153,7 @@ async function onApiLoaded() {
(_event, id: string, newConfig: PluginConfig) => {
const plugin = getAllLoadedRendererPlugins()[id];
if (plugin && typeof plugin.renderer !== 'function') {
plugin.renderer?.onConfigChange?.bind(plugin.renderer)?.(newConfig);
plugin.renderer?.onConfigChange?.call(plugin.renderer, newConfig);
}
},
);

11
src/utils/index.ts
View File

@ -85,8 +85,6 @@ export const startPlugin = <Config extends PluginConfig>(
>
)?.start;
if (!lifecycle) return null;
try {
// HACK: for bind 'this' to context
const defContext = def[options.ctx];
@ -100,7 +98,9 @@ export const startPlugin = <Config extends PluginConfig>(
}
const start = performance.now();
lifecycle.bind(def[options.ctx])(
lifecycle?.call(
defContext,
options.context as Config & typeof options.context,
);
@ -110,7 +110,7 @@ export const startPlugin = <Config extends PluginConfig>(
} ms`,
);
return true;
return lifecycle ? true : null;
} catch (err) {
console.error(LoggerPrefix, `Failed to start ${id}::${options.ctx}`);
console.trace(err);
@ -132,7 +132,8 @@ export const stopPlugin = <Config extends PluginConfig>(
try {
const stop = defCtx.stop;
const start = performance.now();
stop.bind(def[options.ctx])(
stop.call(
def[options.ctx],
options.context as Config & typeof options.context,
);