fix: fixed issues identified in eslint

This commit is contained in:
JellyBrick
2023-11-09 10:06:03 +09:00
parent 05564d4a58
commit 55ae9eac1e
10 changed files with 20 additions and 14 deletions

View File

@ -1,2 +1 @@
.eslintrc.js
electron.vite.config.ts

View File

@ -26,7 +26,7 @@ module.exports = {
'import/newline-after-import': 'error',
'import/no-default-export': 'off',
'import/no-duplicates': 'error',
'import/no-unresolved': ['error', { ignore: ['^virtual:'] }],
'import/no-unresolved': ['error', { ignore: ['^virtual:', '\\?inline$', '\\?raw$', '\\?asset&asarUnpack', '^youtubei.js$'] }],
'import/order': [
'error',
{

View File

@ -148,6 +148,7 @@
"butterchurn-presets": "3.0.0-beta.4",
"conf": "10.2.0",
"custom-electron-prompt": "1.5.7",
"dbus-next": "0.10.2",
"electron-debug": "3.2.0",
"electron-is": "3.0.0",
"electron-localshortcut": "3.2.1",

3
pnpm-lock.yaml generated
View File

@ -55,6 +55,9 @@ dependencies:
custom-electron-prompt:
specifier: 1.5.7
version: 1.5.7(electron@27.0.3)
dbus-next:
specifier: 0.10.2
version: 0.10.2
electron-debug:
specifier: 3.2.0
version: 3.2.0

View File

@ -7,7 +7,6 @@ import maximizeRaw from './assets/maximize.svg?inline';
import unmaximizeRaw from './assets/unmaximize.svg?inline';
import type { Menu } from 'electron';
import * as electron from 'electron';
function $<E extends Element = Element>(selector: string) {
return document.querySelector<E>(selector);

View File

@ -1,7 +1,7 @@
declare module '@jellybrick/mpris-service' {
import { EventEmitter } from 'events';
import dbus from 'dbus-next';
import { interface as dbusInterface } from 'dbus-next';
interface RootInterfaceOptions {
@ -101,7 +101,7 @@ declare module '@jellybrick/mpris-service' {
static LOOP_STATUS_PLAYLIST: 'Playlist';
}
interface MprisInterface extends dbus.interface.Interface {
interface MprisInterface extends dbusInterface.Interface {
setProperty(property: string, valuePlain: unknown): void;
}

View File

@ -1,3 +1,5 @@
/* eslint-disable @typescript-eslint/no-var-requires */
const { test, expect } = require('@playwright/test');
const { sortSegments } = require('../segments');

View File

@ -8,13 +8,13 @@ export abstract class Visualizer<T> {
abstract visualizer: T;
protected constructor(
audioContext: AudioContext,
audioSource: MediaElementAudioSourceNode,
visualizerContainer: HTMLElement,
canvas: HTMLCanvasElement,
audioNode: GainNode,
stream: MediaStream,
options: ConfigType<'visualizer'>,
_audioContext: AudioContext,
_audioSource: MediaElementAudioSourceNode,
_visualizerContainer: HTMLElement,
_canvas: HTMLCanvasElement,
_audioNode: GainNode,
_stream: MediaStream,
_options: ConfigType<'visualizer'>,
) {}
abstract resize(width: number, height: number): void;

View File

@ -22,7 +22,7 @@ enabledPluginNameAndOptions.forEach(async ([plugin, options]) => {
if (Object.hasOwn(preloadPluginList, plugin)) {
const handler = preloadPluginList[plugin];
try {
await handler?.();
await handler?.(options);
} catch (error) {
console.error(`Error in plugin "${plugin}": ${String(error)}`);
}

View File

@ -14,7 +14,9 @@ declare module 'virtual:MenuPlugins' {
}
declare module 'virtual:PreloadPlugins' {
export const pluginList: Record<string, () => Promise<void>>;
import type { ConfigType } from './config/dynamic';
export const pluginList: Record<string, (options: ConfigType) => Promise<void>>;
}
declare module 'virtual:RendererPlugins' {