From 9ff40611cea913e25dde0a0255be889415a7be2d Mon Sep 17 00:00:00 2001 From: Araxeus <78568641+Araxeus@users.noreply.github.com> Date: Thu, 2 Mar 2023 18:18:13 +0200 Subject: [PATCH 1/2] fix unescaped url params fix #1050 --- plugins/lyrics-genius/back.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/lyrics-genius/back.js b/plugins/lyrics-genius/back.js index 05548648..21e91811 100644 --- a/plugins/lyrics-genius/back.js +++ b/plugins/lyrics-genius/back.js @@ -22,7 +22,7 @@ const fetchFromGenius = async (metadata) => { metadata.title )}`; let response = await fetch( - `https://genius.com/api/search/multi?per_page=5&q=${encodeURI(queryString)}` + `https://genius.com/api/search/multi?per_page=5&q=${encodeURIComponent(queryString)}` ); if (!response.ok) { return null; From 16a0b6a8934ee8ffc215bd4534e5583f851ae497 Mon Sep 17 00:00:00 2001 From: Araxeus <78568641+Araxeus@users.noreply.github.com> Date: Thu, 2 Mar 2023 18:20:09 +0200 Subject: [PATCH 2/2] add slight delay to lyrics genius this allows youtube to finish doing it's stuff fix #1041 and other lyrics issues --- plugins/lyrics-genius/front.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/lyrics-genius/front.js b/plugins/lyrics-genius/front.js index c62bfb0c..5725d1e1 100644 --- a/plugins/lyrics-genius/front.js +++ b/plugins/lyrics-genius/front.js @@ -2,7 +2,7 @@ const { ipcRenderer } = require("electron"); const is = require("electron-is"); module.exports = () => { - ipcRenderer.on("update-song-info", (_, extractedSongInfo) => { + ipcRenderer.on("update-song-info", (_, extractedSongInfo) => setTimeout(() => { const tabList = document.querySelectorAll("tp-yt-paper-tab"); const tabs = { upNext: tabList[0], @@ -90,5 +90,5 @@ module.exports = () => { tabs.lyrics.removeAttribute("disabled"); tabs.lyrics.removeAttribute("aria-disabled"); } - }); + }, 500)); };