From 3640527c8c0543c581693be388c68318e196e40f Mon Sep 17 00:00:00 2001 From: JellyBrick Date: Sat, 7 Sep 2024 18:27:36 +0900 Subject: [PATCH] fix(synced-lyrics): LRCLIB returns 0 results if album is undefined - inspired by #2381 --- src/plugins/synced-lyrics/renderer/lyrics/fetch.ts | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/plugins/synced-lyrics/renderer/lyrics/fetch.ts b/src/plugins/synced-lyrics/renderer/lyrics/fetch.ts index 2f7283a5..657321ac 100644 --- a/src/plugins/synced-lyrics/renderer/lyrics/fetch.ts +++ b/src/plugins/synced-lyrics/renderer/lyrics/fetch.ts @@ -52,10 +52,13 @@ export const makeLyricsRequest = async (extractedSongInfo: SongInfo) => { const songData: Parameters[0] = { title: `${extractedSongInfo.title}`, artist: `${extractedSongInfo.artist}`, - album: `${extractedSongInfo.album}`, songDuration: extractedSongInfo.songDuration, }; + if (extractedSongInfo.album) { + songData.album = extractedSongInfo.album; + } + let lyrics; try { lyrics = await getLyricsList(songData); @@ -78,9 +81,9 @@ export const getLyricsList = async ( track_name: songData.title, }); - query.set('album_name', songData.album!); - if (query.get('album_name') === 'undefined') { - query.delete('album_name'); + + if (songData.album) { + query.set('album_name', songData.album); } let url = `https://lrclib.net/api/search?${query.toString()}`;