From b04e2ea13075b667856b96763f59c8829fda9faf Mon Sep 17 00:00:00 2001 From: TC Date: Fri, 8 Jan 2021 22:26:44 +0100 Subject: [PATCH 1/3] Defensive: handle null/undefined ffmpeg args --- plugins/downloader/youtube-dl.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/downloader/youtube-dl.js b/plugins/downloader/youtube-dl.js index 3b0c7688..890659f3 100644 --- a/plugins/downloader/youtube-dl.js +++ b/plugins/downloader/youtube-dl.js @@ -87,7 +87,7 @@ const toMP3 = async ( await ffmpeg.run( "-i", safeVideoName, - ...options.ffmpegArgs, + ...(options.ffmpegArgs || []), safeVideoName + ".mp3" ); From 6a100c8cb16c36f567439523004dde9bae41213d Mon Sep 17 00:00:00 2001 From: TC Date: Fri, 8 Jan 2021 22:29:25 +0100 Subject: [PATCH 2/3] Allow custom audio extensions in downloader --- plugins/downloader/youtube-dl.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/plugins/downloader/youtube-dl.js b/plugins/downloader/youtube-dl.js index 890659f3..e2f57575 100644 --- a/plugins/downloader/youtube-dl.js +++ b/plugins/downloader/youtube-dl.js @@ -73,6 +73,7 @@ const toMP3 = async ( options ) => { const safeVideoName = randomBytes(32).toString("hex"); + const extension = options.extension || "mp3"; try { if (!ffmpeg.isLoaded()) { @@ -88,14 +89,16 @@ const toMP3 = async ( "-i", safeVideoName, ...(options.ffmpegArgs || []), - safeVideoName + ".mp3" + safeVideoName + "." + extension ); const folder = options.downloadFolder || downloadsFolder(); - const filename = filenamify(videoName + ".mp3", { replacement: "_" }); + const filename = filenamify(videoName + "." + extension, { + replacement: "_", + }); writeFileSync( join(folder, filename), - ffmpeg.FS("readFile", safeVideoName + ".mp3") + ffmpeg.FS("readFile", safeVideoName + "." + extension) ); reinit(); From a9a840b6c3158536f5c4d3927d74a1b9dda9604f Mon Sep 17 00:00:00 2001 From: TC Date: Fri, 8 Jan 2021 22:41:17 +0100 Subject: [PATCH 3/3] Bump version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index c24d6069..00beabb7 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "youtube-music", "productName": "YouTube Music", - "version": "1.8.0", + "version": "1.8.1", "description": "YouTube Music Desktop App - including custom plugins", "license": "MIT", "repository": "th-ch/youtube-music",