From 9b0259176760b3639077c9ff9bf055d95dec134d Mon Sep 17 00:00:00 2001 From: TC Date: Mon, 23 Nov 2020 22:52:00 +0100 Subject: [PATCH 1/5] Test that menu bar is visible --- tests/index.test.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/index.test.js b/tests/index.test.js index 9fd1d57b..9ab4bf63 100644 --- a/tests/index.test.js +++ b/tests/index.test.js @@ -6,6 +6,9 @@ describe("YouTube Music App", () => { const win = app.browserWindow; + const isMenuVisible = await win.isMenuBarVisible(); + expect(isMenuVisible).toBe(true); + const isVisible = await win.isVisible(); expect(isVisible).toBe(true); From cf4827d780fee510a27eecf42453b0505c52bcf9 Mon Sep 17 00:00:00 2001 From: TC Date: Mon, 23 Nov 2020 22:55:20 +0100 Subject: [PATCH 2/5] Run CI on every push/PR --- .github/workflows/build.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e7868ed4..3a0b6ead 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,12 +1,8 @@ name: Build YouTube Music on: - push: - branches: - - master - pull_request: - branches: - - master + - push + - pull_request jobs: build: From 72527d052271662c09df34f3068f2af952391dfb Mon Sep 17 00:00:00 2001 From: TC Date: Mon, 23 Nov 2020 22:59:48 +0100 Subject: [PATCH 3/5] Disable autoHideMenuBar (so menu bar is always visible) --- index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/index.js b/index.js index 08a72b06..1f45b7bc 100644 --- a/index.js +++ b/index.js @@ -85,7 +85,6 @@ function createMainWindow() { }, frame: !is.macOS(), titleBarStyle: is.macOS() ? "hiddenInset" : "default", - autoHideMenuBar: true, }); if (windowMaximized) { win.maximize(); From db447a5d625c87fef21ec0a366bd7775a9aedb35 Mon Sep 17 00:00:00 2001 From: TC Date: Mon, 23 Nov 2020 23:04:16 +0100 Subject: [PATCH 4/5] Bump patch version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index b1fd82e1..df6e509b 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "youtube-music", "productName": "YouTube Music", - "version": "1.6.2", + "version": "1.6.3", "description": "YouTube Music Desktop App - including custom plugins", "license": "MIT", "repository": "th-ch/youtube-music", From 3bc8430201c001fffb0d189aee5fb8cf3e99a11f Mon Sep 17 00:00:00 2001 From: TC Date: Mon, 23 Nov 2020 23:11:44 +0100 Subject: [PATCH 5/5] No CI run on pull_request (already on every push) --- .github/workflows/build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3a0b6ead..e48db775 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -2,7 +2,6 @@ name: Build YouTube Music on: - push - - pull_request jobs: build: