feat: enable rolldown native plugin (#3502)

electron.vite.config.mts

@@ -1,16 +1,17 @@
 import { dirname, join, resolve } from 'node:path';
 import { fileURLToPath } from 'node:url';
 
-import { UserConfig } from 'vite';
 import { defineConfig, defineViteConfig } from 'electron-vite';
 import builtinModules from 'builtin-modules';
-import viteResolve from 'vite-plugin-resolve';
+
 import Inspect from 'vite-plugin-inspect';
 import solidPlugin from 'vite-plugin-solid';
+import viteResolve from 'vite-plugin-resolve';
+
+import { withFilter, type UserConfig } from 'vite';
 
 import { pluginVirtualModuleGenerator } from './vite-plugins/plugin-importer.mjs';
 import pluginLoader from './vite-plugins/plugin-loader.mjs';
-
 import { i18nImporter } from './vite-plugins/i18n-importer.mjs';
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
@@ -23,6 +24,9 @@ const resolveAlias = {
 export default defineConfig({
   main: defineViteConfig(({ mode }) => {
     const commonConfig: UserConfig = {
+      experimental: {
+        enableNativePlugin: true,
+      },
       plugins: [
         pluginLoader('backend'),
         viteResolve({
@@ -72,6 +76,9 @@ export default defineConfig({
   }),
   preload: defineViteConfig(({ mode }) => {
     const commonConfig: UserConfig = {
+      experimental: {
+        enableNativePlugin: true,
+      },
       plugins: [
         pluginLoader('preload'),
         viteResolve({
@@ -120,13 +127,18 @@ export default defineConfig({
   }),
   renderer: defineViteConfig(({ mode }) => {
     const commonConfig: UserConfig = {
+      experimental: {
+        enableNativePlugin: mode !== 'development', // Disable native plugin in development mode to avoid issues with HMR (bug in rolldown-vite)
+      },
       plugins: [
         pluginLoader('renderer'),
         viteResolve({
           'virtual:i18n': i18nImporter(),
           'virtual:plugins': pluginVirtualModuleGenerator('renderer'),
         }),
-        solidPlugin(),
+        withFilter(solidPlugin(), {
+          load: { id: [/\.(tsx|jsx)$/, '/@solid-refresh'] },
+        }),
       ],
       root: './src/',
       build: {

vite-plugins/plugin-loader.mts

@@ -2,7 +2,6 @@ import { readFileSync } from 'node:fs';
 import { resolve, basename, dirname } from 'node:path';
 import { fileURLToPath } from 'node:url';
 
-import { createFilter } from 'vite';
 import {
   Project,
   ts,
@@ -39,17 +38,13 @@ const getPropertyName = (prop: Node): string | null => {
 export default function (
   mode: 'backend' | 'preload' | 'renderer' | 'none',
 ): PluginOption {
-  const pluginFilter = createFilter([
-    'src/plugins/*/index.{js,ts}',
-    'src/plugins/*',
-  ]);
-
   return {
     name: 'ytm-plugin-loader',
-    load(id) {
+    load: {
-      if (!pluginFilter(id)) return null;
+      filter: {
-
+        id: /(?:\/plugins\/[^/]+\/index\.(?:js|ts|jsx|tsx)|\/plugins\/[^/]+\.(?:js|ts|jsx|tsx))$/,
-      // Read file asynchronously
+      },
+      handler(id) {
         const fileContent = readFileSync(id, 'utf8');
         // Create or update source file in the global project instance
         const src = globalProject.createSourceFile(
@@ -58,19 +53,49 @@ export default function (
           { overwrite: true },
         );
 
-      const exports = src.getExportedDeclarations();
         let objExpr: ObjectLiteralExpression | undefined;
 
-      // Identify the default export as an object literal, or via a 'createPlugin' call
+        // Check for `export default ...`
-      for (const [exportName, declarations] of exports) {
+        const defaultExportAssignment = src.getExportAssignment(
-        if (exportName !== 'default') continue;
+          (ea) => !ea.isExportEquals(), // Filter out `export = `
-        const expr = declarations[0];
+        );
 
-        const exprKind = expr.getKind();
+        if (defaultExportAssignment) {
-        if (exprKind === ts.SyntaxKind.ObjectLiteralExpression) {
+          const expression = defaultExportAssignment.getExpression();
-          objExpr = expr.asKindOrThrow(ts.SyntaxKind.ObjectLiteralExpression);
+          if (expression.getKind() === ts.SyntaxKind.ObjectLiteralExpression) {
-          break;
+            objExpr = expression.asKindOrThrow(
-        } else if (exprKind === ts.SyntaxKind.CallExpression) {
+              ts.SyntaxKind.ObjectLiteralExpression,
+            );
+          } else if (expression.getKind() === ts.SyntaxKind.CallExpression) {
+            const callExpr = expression.asKindOrThrow(
+              ts.SyntaxKind.CallExpression,
+            );
+            if (
+              callExpr.getArguments().length === 1 &&
+              callExpr.getExpression().getText() === 'createPlugin'
+            ) {
+              const arg = callExpr.getArguments()[0];
+              if (arg.getKind() === ts.SyntaxKind.ObjectLiteralExpression) {
+                objExpr = arg.asKindOrThrow(
+                  ts.SyntaxKind.ObjectLiteralExpression,
+                );
+              }
+            }
+          }
+        }
+
+        // If not found via `export default`, check for a named export aliased as 'default'
+        if (!objExpr) {
+          const defaultExportDeclaration = src
+            .getExportedDeclarations()
+            .get('default');
+          if (defaultExportDeclaration && defaultExportDeclaration.length > 0) {
+            const expr = defaultExportDeclaration[0];
+            if (expr.getKind() === ts.SyntaxKind.ObjectLiteralExpression) {
+              objExpr = expr.asKindOrThrow(
+                ts.SyntaxKind.ObjectLiteralExpression,
+              );
+            } else if (expr.getKind() === ts.SyntaxKind.CallExpression) {
               const callExpr = expr.asKindOrThrow(ts.SyntaxKind.CallExpression);
               if (
                 callExpr.getArguments().length === 1 &&
@@ -81,7 +106,7 @@ export default function (
                   objExpr = arg.asKindOrThrow(
                     ts.SyntaxKind.ObjectLiteralExpression,
                   );
-              break;
+                }
               }
             }
           }
@@ -142,5 +167,6 @@ export default function (
           code: src.getText(),
         };
       },
+    },
   };
 }